omit namespace from service checks & events #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We noticed that our Rust app wasn't sending events to Datadog, and discovered Datadog was failing to parse the event "metric":
Solution
As it turns out, neither events nor service checks are supposed to have the
namespace.
prefix, so it needs to be removed.Implementation
As
format_for_send
seems to be the nexus for all message formatting logic, I changed itsmetric
argument to acceptMetric
values, which now indicate whether the namespace prefix should be added based onuses_namespace
. This resulted in some changes to the expected test values, since I had to pass in an exampleCountMetric
to the updatedformat_for_send
function.